Re: [Qemu-ppc] [PATCH 0/2] configure: Fix make check-tcg for ppc64le

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 5/1/19 9:04 PM, David Gibson wrote:
>> I've staged this tentatively in ppc-for-4.1.  However while it removes
>> the "Invalid ELF image" message I still get:
>>
>>   TEST    test-mmap (4096 byte pages) on ppc64le
>> test-mmap: Invalid argument
>> make[2]: *** [/home/dwg/qemu/tests/tcg/multiarch/Makefile.target:35: 
>> run-test-mmap-4096] Error 255
>> make[2]: Target 'run' not remade because of errors.
>> make[1]: *** [/home/dwg/qemu/tests/tcg/Makefile.include:71: run-guest-tests] 
>> Error 2
>> make: *** [/home/dwg/qemu/tests/Makefile.include:1079: 
>> run-tcg-tests-ppc64le-linux-user] Error 2
>>
>> Running on a POWER9 host.  Do you see that as well?
>
> Yes.
>
> It's a semi-bogus test, really.  We can't run test-mmap
> with a page size smaller than that of the host, and of
> course ppc64le uses 64k pages.

The default run-test-mmap should just run against the host page size
(which may be bogus for the emulated architecture). The additional runs
are all added with EXTRA_RUNS:

  EXTRA_RUNS+=run-test-mmap-4096 #run-test-mmap-65536

Currently the 64k pages are disabled because it crashes so somebody
should probably look into that.

Looking at -p setting the confusing named qemu_host_page_size doesn't
seem to reflect this in:

  #ifdef TARGET_NR_getpagesize
      case TARGET_NR_getpagesize:
          return TARGET_PAGE_SIZE;
  #endif

> This needs a different set of cleanups.  ;-)

I guess this is another use case for softmmu support in linux-user where
HOST_PAGE != TARGET_PAGE?

--
Alex Bennée