Re: [Qemu-ppc] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interface

[Maxiwell S. Garcia]

Hi,

On Thu, Mar 28, 2019 at 02:21:51PM +0100, Greg Kurz wrote:
> On Wed, 27 Mar 2019 17:41:00 -0300
> "Maxiwell S. Garcia" <address@hidden> wrote:
> 
> > Here are two patches to add a handler for ibm,get-vpd RTAS calls.
> > This RTAS exposes host information in case of set QEMU options
> > 'host-serial' and 'host-model' as 'passthrough'.
> > 
> > The patch 1 creates helper functions to get valid 'host-serial'
> > and 'host-model' parameters, guided by QEMU command line. These
> > parameters are useful to build the guest device tree and to return
> > get-vpd RTAS calls. The patch 2 adds the ibm,get-vpd itself.
> > 
> > Update v7:
> > * rtas_get_vpd_fields as a static array in spapr machine state
> > 
> > Maxiwell S. Garcia (2):
> >   spapr: helper functions to get valid host fields
> >   spapr-rtas: add ibm,get-vpd RTAS interface
> > 
> >  hw/ppc/spapr.c         | 48 +++++++++++----------
> >  hw/ppc/spapr_rtas.c    | 96 ++++++++++++++++++++++++++++++++++++++++++
> >  include/hw/ppc/spapr.h | 14 +++++-
> >  3 files changed, 135 insertions(+), 23 deletions(-)
> > 
> 
> Hi Maxiwell,
> 
> David sent a patch to rework how the host data is exposed to the guest.
> Especially, the special casing of the "none" and "passthrough" strings
> is no more... I'm afraid you'll have to rework your patches accordingly:
> code+changelog in patch 1 and at least changelog in patch 2.
> 
> Cheers,

IIUC, the 'ibm,get-vpd' RTAS should return information about the
platform/cabinet. Thus, it's not necessary to add new nodes in the guest
device tree to export information like that. Since it's a POWER specific
functionality, may 'ibm,get-vpd' export host information if the
guest instance allows it? Or is it better return only the 'host-serial'
and 'host-model' content, like in the patch "spapr: Simplify handling
of host-serial and host-model values"?

> 
> --
> Greg
>