[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC for-4.1 21/25] target/ppc: Style fixes for translate
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [RFC for-4.1 21/25] target/ppc: Style fixes for translate.c |
Date: |
Tue, 26 Mar 2019 11:21:12 +1100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Mon, Mar 25, 2019 at 10:56:34AM +0100, Greg Kurz wrote:
> On Fri, 22 Mar 2019 11:15:40 +1100
> David Gibson <address@hidden> wrote:
>
> > Signed-off-by: David Gibson <address@hidden>
[snip]
> > @@ -2916,10 +2955,11 @@ static void gen_stmw(DisasContext *ctx)
> > /*** Integer load and store strings
> > ***/
> >
> > /* lswi */
> > -/* PowerPC32 specification says we must generate an exception if
> > - * rA is in the range of registers to be loaded.
> > - * In an other hand, IBM says this is valid, but rA won't be loaded.
> > - * For now, I'll follow the spec...
> > +/*
> > + * PowerPC32 specification says we must generate an exception if rA is
> > + * in the range of registers to be loaded. In an other hand, IBM says
> > + * this is valid, but rA won't be loaded. For now, I'll follow the
> > + * spec...
> > */
>
> Merge with the preceding comment ?
Actually, I think I'll leave it. The one-liner serves a different
purpose and has a different format to the block below.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [RFC for-4.1 12/25] target/ppc: Style fixes for machine.c, (continued)
- [Qemu-ppc] [RFC for-4.1 12/25] target/ppc: Style fixes for machine.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_regs.h, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 02/25] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h", David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 04/25] target/ppc: Style fixes for cpu.[ch], David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 21/25] target/ppc: Style fixes for translate.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 07/25] target/ppc: Style fixes for dfp_helper.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 18/25] target/ppc: Style fixes for mmu_helper.c, David Gibson, 2019/03/21
- [Qemu-ppc] [RFC for-4.1 20/25] target/ppc: Style fixes for translate_init.inc.c, David Gibson, 2019/03/21