[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 14/14] pflash: Clean up after commit 368a354f02
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-ppc] [PATCH v3 14/14] pflash: Clean up after commit 368a354f02b, part 2 |
|
Date: |
Fri, 8 Mar 2019 15:05:31 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/7/19 2:03 PM, Markus Armbruster wrote:
> Our pflash devices are simplistically modelled has having
> "num-blocks" sectors of equal size "sector-length". Real hardware
> commonly has sectors of different sizes. How our "sector-length"
> property is related to the physical device's multiple sector sizes
> is unclear.
>
> Helper functions pflash_cfi01_register() and pflash_cfi02_register()
> create a pflash device, set properties including "sector-length" and
> "num-blocks", and realize. They take parameters @size, @sector_len
> and @nb_blocs.
>
> QOMification left parameter @size unused. Obviously, @size should
> match @sector_len and @nb_blocs, i.e. size == sector_len * nb_blocs.
> All callers satisfy this.
>
> Remove @nb_blocs and compute it from @size and @sector_len.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Laszlo Ersek <address@hidden>
> Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 07/14] ppc405_boards: Don't size flash memory to match backing image, (continued)
- [Qemu-ppc] [PATCH v3 13/14] pflash: Clean up after commit 368a354f02b, part 1, Markus Armbruster, 2019/03/07
- [Qemu-ppc] [PATCH v3 14/14] pflash: Clean up after commit 368a354f02b, part 2, Markus Armbruster, 2019/03/07
- Re: [Qemu-ppc] [PATCH v3 14/14] pflash: Clean up after commit 368a354f02b, part 2,
Philippe Mathieu-Daudé <=
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 00/14] pflash: Fixes and cleanups, no-reply, 2019/03/09