Re: [Qemu-ppc] [Qemu-devel] [PATCH qemu] spapr: Fix fdt warnings

[BALATON Zoltan]

On Wed, 16 Jan 2019, Richard Henderson wrote:
> On 1/16/19 3:19 PM, Alexey Kardashevskiy wrote:
> > because TARGET_FMT_lx is defined as "%016"PRIx64.
> >
> > This uses simple "%lx" to suppress the warning. Since it is spapr which
> > is always 64bit, we assume here that hwaddr is always "long".
>
> This file is not solely for kvm, i.e. ppc64 hosts.  Thus this
> is a bad assumption and will fail for a 32-bit host.
>
> You may want to use PRIx64 and assume hwaddr == uint64_t, or
> also include an explicit cast to uint64_t.

I don't know the context of this but there's HWADDR_PRIx as well so if you 
want to print a hwaddr that's probably the one to use.

Regards,
BALATON Zoltan