Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

[Greg Kurz]

On Thu, 10 Jan 2019 10:12:43 +0000
Daniel P. Berrangé <address@hidden> wrote:

> On Wed, Jan 09, 2019 at 03:25:53PM -0600, Eric Blake wrote:
> > On 1/9/19 3:20 PM, Paolo Bonzini wrote:  
> > > On 09/01/19 18:28, Daniel P. Berrangé wrote:  
> > >>> so both files include each other, how nice ...  
> > >> If the header files are mutually dependent it makes me wonder what the
> > >> point of having them split up is ?
> > >>
> > >> Feels like either they need to be merged, or they need to be split up
> > >> and refactored even more to remove the mutual dependancy.  
> > > 
> > > If they include each other only for the typedefs, then prehaps the
> > > solution is to change the coding style and allow using struct in
> > > function prototypes.  I'm pretty sure there are several examples of this
> > > already.  
> > 
> > Or stick the typedef in <typedefs.h>, instead of trying to find (or
> > create) some other common header.  
> 
> Probably better to just have a local  spapr_types.h instead of
> polluting the global namespace.
> 

I personally like this approach because it would allow to use the
typedefs everywhere, for the sake of consistency.

> 
> Regards,
> Daniel