[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM defi
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-ppc] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM definition |
Date: |
Mon, 7 Jan 2019 08:56:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/7/19 7:32 AM, Thomas Huth wrote:
> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
>> Introduced in 64b40bc54a9, this definition is no more used since
>> a0b753dfd39. Remove it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> include/hw/devices.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/hw/devices.h b/include/hw/devices.h
>> index 0e27feb0c2..4019b3be17 100644
>> --- a/include/hw/devices.h
>> +++ b/include/hw/devices.h
>> @@ -51,7 +51,6 @@ void retu_key_event(void *retu, int state);
>>
>> /* tc6393xb.c */
>> typedef struct TC6393xbState TC6393xbState;
>> -#define TC6393XB_RAM 0x110000 /* amount of ram for Video and USB */
>> TC6393xbState *tc6393xb_init(struct MemoryRegion *sysmem,
>> uint32_t base, qemu_irq irq);
>> void tc6393xb_gpio_out_set(TC6393xbState *s, int line,
>>
>
> I think I'd simply squash this into the next patch and mention it in the
> patch description there that you removed the #define.
OK.
- [Qemu-ppc] [PATCH 00/16] hw: Remove "hw/devices.h", Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-ppc] [PATCH 01/16] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-ppc] [PATCH 02/16] hw: Remove unused 'hw/devices.h' include, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-ppc] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM definition, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-ppc] [PATCH 04/16] hw/devices: Move TC6393XB declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-ppc] [PATCH 05/16] hw/devices: Move Blizzard declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-ppc] [PATCH 06/16] hw/devices: Move CBus declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-ppc] [PATCH 07/16] hw/devices: Move Gamepad declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-ppc] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI touchscreen devices, Philippe Mathieu-Daudé, 2019/01/04