[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL v2 01/43] hostmem-file: fixed the memory leak while get
From: |
Eduardo Habkost |
Subject: |
[Qemu-ppc] [PULL v2 01/43] hostmem-file: fixed the memory leak while get pmem path. |
Date: |
Thu, 25 Oct 2018 10:32:19 -0300 |
From: Zhang Yi <address@hidden>
object_get_canonical_path_component() returns a string which
must be freed using g_free().
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Zhang Yi <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
backends/hostmem-file.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
index e64074954f..639c8d4307 100644
--- a/backends/hostmem-file.c
+++ b/backends/hostmem-file.c
@@ -145,20 +145,26 @@ static void file_memory_backend_set_pmem(Object *o, bool
value, Error **errp)
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
if (host_memory_backend_mr_inited(backend)) {
+ char *path = object_get_canonical_path_component(o);
+
error_setg(errp, "cannot change property 'pmem' of %s '%s'",
object_get_typename(o),
- object_get_canonical_path_component(o));
+ path);
+ g_free(path);
return;
}
#ifndef CONFIG_LIBPMEM
if (value) {
Error *local_err = NULL;
+ char *path = object_get_canonical_path_component(o);
+
error_setg(&local_err,
"Lack of libpmem support while setting the 'pmem=on'"
" of %s '%s'. We can't ensure data persistence.",
object_get_typename(o),
- object_get_canonical_path_component(o));
+ path);
+ g_free(path);
error_propagate(errp, local_err);
return;
}
--
2.18.0.rc1.1.g3f1ff2140
- [Qemu-ppc] [PULL v2 08/43] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init, (continued)
- [Qemu-ppc] [PULL v2 06/43] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 04/43] trace-events: Fix copy/paste typo, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 03/43] vl:c: make sure that sockets are calculated correctly in '-smp X' case, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 02/43] vl.c deprecate incorrect CPUs topology, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 01/43] hostmem-file: fixed the memory leak while get pmem path.,
Eduardo Habkost <=
- [Qemu-ppc] [PULL v2 20/43] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 17/43] memory-device: fix alignment error message, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 13/43] hw/alpha/typhoon: Remove unuseful code, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 10/43] hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 19/43] memory-device: improve "range conflicts" error message, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 14/43] hw/hppa/dino: Remove unuseful code, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 15/43] hw/mips/malta: Remove unuseful code, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 12/43] hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device', Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 18/43] memory-device: fix error message when hinted address is too small, Eduardo Habkost, 2018/10/25
- [Qemu-ppc] [PULL v2 22/43] memory-device: introduce separate config option, Eduardo Habkost, 2018/10/25