[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v5 03/16] memory-device: improve "range conflicts" err
From: |
David Hildenbrand |
Subject: |
[Qemu-ppc] [PATCH v5 03/16] memory-device: improve "range conflicts" error message |
Date: |
Fri, 5 Oct 2018 11:20:11 +0200 |
Handle id==NULL better and indicate that we are dealing with memory
devices.
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/mem/memory-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 7c706fadfc..0624184c40 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -175,7 +175,8 @@ uint64_t memory_device_get_free_addr(MachineState *ms,
const uint64_t *hint,
if (ranges_overlap(md_addr, md_size, new_addr, size)) {
if (hint) {
const DeviceState *d = DEVICE(md);
- error_setg(errp, "address range conflicts with '%s'", d->id);
+ error_setg(errp, "address range conflicts with memory device"
+ " id='%s'", d->id ? d->id : "(unnamed)");
goto out;
}
new_addr = QEMU_ALIGN_UP(md_addr + md_size, align);
--
2.17.1
- [Qemu-ppc] [PATCH v5 15/16] memory-device: complete factoring out unplug handling, (continued)
- [Qemu-ppc] [PATCH v5 15/16] memory-device: complete factoring out unplug handling, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 14/16] memory-device: complete factoring out plug handling, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 12/16] memory-device: add device class function set_addr(), David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 10/16] memory-device: factor out get_memory_region() from pc-dimm, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 11/16] memory-device: drop get_region_size(), David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 13/16] memory-device: complete factoring out pre_plug handling, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 08/16] memory-device: document MemoryDeviceClass, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 09/16] memory-device: add and use memory_device_get_region_size(), David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 04/16] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 02/16] memory-device: fix error message when hinted address is too small, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 03/16] memory-device: improve "range conflicts" error message,
David Hildenbrand <=
- [Qemu-ppc] [PATCH v5 07/16] memory-device: forward errors in get_region_size()/get_plugged_size(), David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 05/16] memory-device: use memory device terminology in error messages, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 06/16] memory-device: introduce separate config option, David Hildenbrand, 2018/10/05
- [Qemu-ppc] [PATCH v5 01/16] memory-device: fix alignment error message, David Hildenbrand, 2018/10/05
- Re: [Qemu-ppc] [PATCH v5 00/16] memory-device: complete refactoring, David Hildenbrand, 2018/10/09