[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Drop the "qemu:" prefix from error_r
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Drop the "qemu:" prefix from error_report() |
|
Date: |
Thu, 20 Sep 2018 20:59:51 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eduardo Habkost <address@hidden> writes:
> On Thu, Sep 20, 2018 at 07:08:32AM -0400, Mao Zhongyi wrote:
>> error_report and friends already add a "qemu-system-xxx" prefix
>> to the string, so a "qemu:" prefix is redundant in the string.
>> Just drop it.
>>
>> Reported-by: Thomas Huth <address@hidden>
>> Signed-off-by: Mao Zhongyi <address@hidden>
>
> Reviewed-by: Eduardo Habkost <address@hidden>
>
> Markus, do you want to merge it through your tree?
Yes.
> If we are already touching those messages, it would be nice if we
> removed punctuation too on some cases below[1].
Yes. Done in my tree.
I'm also tweaking the subject to
Drop "qemu:" prefix from error_report() arguments
Queued, thanks!