Re: [Qemu-ppc] [PATCH v2 2/3] scsi: move lsi53c8xx_create() callers to lsi53c8xx_handle_legacy_cmdline()

[Thomas Huth]

On 2018-09-07 14:56, Mark Cave-Ayland wrote:
> As part of commits a64aa5785d "hw: Deprecate -drive if=scsi with non-onboard
> HBAs" and b891538e81 "hw/ppc/prep: Fix implicit creation of "-drive if=scsi"
> devices" the lsi53c895a_create() and lsi53c810_create() functions were added
> to wrap pci_create_simple() and scsi_bus_legacy_handle_cmdline().
> 
> Unfortunately this prevents us from changing qdev properties on the device
> and/or changing the PCI configuration. By switching over to using the new
> lsi53c8xx_handle_legacy_cmdline() function then the caller can now configure
> and realize the LSI SCSI device exactly as required.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  hw/arm/realview.c    | 3 ++-
>  hw/arm/versatilepb.c | 3 ++-
>  hw/hppa/machine.c    | 4 +++-
>  hw/ppc/prep.c        | 4 +++-
>  4 files changed, 10 insertions(+), 4 deletions(-)

Reviewed-by: Thomas Huth <address@hidden>