[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH for 3.0] sam460ex: Correct use after
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH for 3.0] sam460ex: Correct use after free error |
|
Date: |
Sun, 15 Jul 2018 19:19:44 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 07/15/2018 05:47 PM, BALATON Zoltan wrote:
> Commit 51b0d834c changed error handling to report file name in error
> message but forgot to move freeing it after usage. Noticed by Coverity.
>
> Fixes: CID 1394217
> Reported-by: Paolo Bonzini <address@hidden>
> Signed-off-by: BALATON Zoltan <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/ppc/sam460ex.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c
> index e2b7028..0999efc 100644
> --- a/hw/ppc/sam460ex.c
> +++ b/hw/ppc/sam460ex.c
> @@ -269,11 +269,12 @@ static int sam460ex_load_device_tree(hwaddr addr,
> exit(1);
> }
> fdt = load_device_tree(filename, &fdt_size);
> - g_free(filename);
> if (!fdt) {
> error_report("Couldn't load dtb file `%s'", filename);
> + g_free(filename);
> exit(1);
> }
> + g_free(filename);
>
> /* Manipulate device tree in memory. */
>
>