Re: [Qemu-ppc] [PATCH] vga: make stdvga the global default

[Mark Cave-Ayland]

On 05/07/18 14:12, Eduardo Habkost wrote:

> > I also checked the code, default values are used also for other fields in
> > that struct (e.g., default_cpus). If default values are considered fragile,
> > they must be changed as well in the middle term. However, given a solid
> > documentation (which is currently missing for these fields) I still think
> > that default values are acceptable.
> >
> > Note that there seems also be the possibility to set != NULL default values
> > in the machine_class_init() function.
>
> I don't mind if the default value is defined at
> machine_class_init() or main().  What bothers me is a default
> value that depends on vga_interface_available(), because it can
> be easily broken by a build config change (as demonstrated by the
> bug fixed by this patch).

I've already sent David a for-3.0 patch to set stdvga for the PPC Mac 
machines, but should I also do the same for PReP too?

Is it also worth explicitly adding this for sun4u? And what about 
non-ISA/PCI cards such as sun4m's TCX/CG3?


ATB,

Mark.