Re: [Qemu-ppc] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations

[Paolo Bonzini]

On 05/07/2018 15:51, Guenter Roeck wrote:
> +        /* Failure to set serial port clocks is not fatal, so just ignore
> +         * errors when trying to do so.
> +         */
> +        (void)fdt_setprop_cell(fdt, offset, "clock-frequency", UART_FREQ);
>          offset = fdt_node_offset_by_compatible(fdt, offset, "ns16550");

Ok, but why would it even fail?  Maybe it's not this case, but even if
it's not fatal for the OS, generating different device trees silently
seems like a recipe for Heisenbugs.

Thanks,

Paolo