Re: [Qemu-ppc] [Qemu-devel] [PULL 35/35] ppc: Include vga cirrus card into the compiling process

[Mark Cave-Ayland]

On 03/07/18 20:24, Sebastian Bauer wrote:

> Am 2018-07-03 21:00, schrieb Mark Cave-Ayland:
> > On 03/07/18 06:58, David Gibson wrote:
> >
> > > From: Sebastian Bauer <address@hidden>
> > >
> > > Drivers for this card exists on PPC-based AmigaOS guests so it is 
> > > useful to
> > > allow users to emulate the graphics card for PPC machines.
> > >
> > > As cirrus vga is currently preferred over std(vga) in absence of any 
> > > user
> > > choice, this change also sets the default display of spapr machines to
> > > std as otherwise qemu refuses to start these machines.
> >
> > ... which has quite nicely broken the VGA display for both the PPC Mac
> > machines. Patch to follow shortly.
>
> Please see my note in the comment section of the patch where I propose 
> two possible solutions:
>
> Either to give up the vga cirrus preference or to apply the same as was 
> done with the spapr machine. I would prefer the first variant but it 
> would also cause some differences on other machines.

I understand that the decision was taken to add VGA cirrus to the PPC 
build and therefore accept the default VGA device change, however your 
the commit message only mentions spapr and not all the other PPC 
machines whose defaults are also potentially affected:

$ ./qemu-system-ppc -M ?
Supported machines are:
40p                  IBM RS/6000 7020 (40p)
bamboo               bamboo
g3beige              Heathrow based PowerMAC (default)
mac99                Mac99 based PowerMAC
mpc8544ds            mpc8544ds
none                 empty machine
ppce500              generic paravirt e500 platform
prep                 PowerPC PREP platform
ref405ep             ref405ep
sam460ex             aCube Sam460ex
taihu                taihu
virtex-ml507         Xilinx Virtex ML507 reference design

I'm not able to personally validate all of these, but a quick check 
shows that at least both PReP machines (-M prep and -M 40p) are also 
broken by this patch which tells me it hasn't had much testing.

David, do you know what the defaults are for the other PPC machines in 
order for Sebastian to test and send a follow-up patch?


ATB,

Mark.