[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check
From: |
Emilio G. Cota |
Subject: |
[Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check |
Date: |
Mon, 2 Jul 2018 18:02:07 -0400 |
The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert
to TranslatorOps", 2018-02-16).
Fix it by setting is_jmp, so that we break from the translation loop
as originally intended.
Tested-by: Mark Cave-Ayland <address@hidden>
Reported-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
---
(I'll send this to qemu-stable (for 2.12) once it's on master.)
---
target/ppc/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 3a215a1..99c2731 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -7314,6 +7314,7 @@ static bool ppc_tr_breakpoint_check(DisasContextBase
*dcbase, CPUState *cs,
DisasContext *ctx = container_of(dcbase, DisasContext, base);
gen_debug_exception(ctx);
+ dcbase->is_jmp = DISAS_NORETURN;
/* The address covered by the breakpoint must be included in
[tb->pc, tb->pc + tb->size) in order to for it to be
properly cleared -- thus we increment the PC here so that
--
2.7.4
- [Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check,
Emilio G. Cota <=