[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH] ppc/pnv: fix pnv_core_realize() error handling
From: |
Cédric Le Goater |
Subject: |
[Qemu-ppc] [PATCH] ppc/pnv: fix pnv_core_realize() error handling |
Date: |
Tue, 26 Jun 2018 16:22:14 +0200 |
commit d35aefa9ae15 ("ppc/pnv: introduce a new intc_create() operation
to the chip model") changed the object link in the pnv_core_realize()
routine but a return was forgotten in case of error, which can lead to
more problems afterwards (segv)
Signed-off-by: Cédric Le Goater <address@hidden>
---
hw/ppc/pnv_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
index a9f129fc2c5f..9750464bf4a1 100644
--- a/hw/ppc/pnv_core.c
+++ b/hw/ppc/pnv_core.c
@@ -150,6 +150,7 @@ static void pnv_core_realize(DeviceState *dev, Error **errp)
if (!chip) {
error_propagate(errp, local_err);
error_prepend(errp, "required link 'chip' not found: ");
+ return;
}
pc->threads = g_new(PowerPCCPU *, cc->nr_threads);
--
2.13.6
- [Qemu-ppc] [PATCH] ppc/pnv: fix pnv_core_realize() error handling,
Cédric Le Goater <=