Re: [Qemu-ppc] [PATCH 4/9] target/ppc: Add kvmppc_hpt_needs_host_contiguous_pages() helper

[David Gibson]

On Thu, Jun 21, 2018 at 07:56:58AM +0200, Cédric Le Goater wrote:
> On 06/18/2018 08:36 AM, David Gibson wrote:
> > KVM HV has a restriction that for HPT mode guests, guest pages must be hpa
> > contiguous as well as gpa contiguous.  We have to account for that in
> > various places.  We determine whether we're subject to this restriction
> > from the SMMU information exposed by KVM.
> > 
> > Planned cleanups to the way we handle this will require knowing whether
> > this restriction is in play in wider parts of the code.  So, expose a
> > helper function which returns it.
> > 
> > This does mean some redundant calls to kvm_get_smmu_info(), but they'll go
> > away again with future cleanups.
> > 
> > Signed-off-by: David Gibson <address@hidden>
> 
> Reviewed-by: Cédric Le Goater <address@hidden>
> 
> but this patch is already committed it seems.

Yeah.  I was pretty confident of these earlier cleanups, so I merged
them with just Greg's R-b.  It's 5-9 I'm particularly in need of
review.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature