[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v5 02/12] pc: rename pc_dimm_(plug|unplug|...)* into p
From: |
David Hildenbrand |
Subject: |
[Qemu-ppc] [PATCH v5 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)* |
Date: |
Tue, 19 Jun 2018 15:41:31 +0200 |
Use a similar naming scheme as spapr. This way, we can go ahead and
rename e.g. pc_dimm_memory_plug to pc_dimm_plug, which avoids
confusion.
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/i386/pc.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 622e49d6bc..f9250ffae7 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1674,8 +1674,8 @@ void ioapic_init_gsi(GSIState *gsi_state, const char
*parent_name)
}
}
-static void pc_dimm_plug(HotplugHandler *hotplug_dev,
- DeviceState *dev, Error **errp)
+static void pc_memory_plug(HotplugHandler *hotplug_dev,
+ DeviceState *dev, Error **errp)
{
HotplugHandlerClass *hhc;
Error *local_err = NULL;
@@ -1728,8 +1728,8 @@ out:
error_propagate(errp, local_err);
}
-static void pc_dimm_unplug_request(HotplugHandler *hotplug_dev,
- DeviceState *dev, Error **errp)
+static void pc_memory_unplug_request(HotplugHandler *hotplug_dev,
+ DeviceState *dev, Error **errp)
{
HotplugHandlerClass *hhc;
Error *local_err = NULL;
@@ -1759,8 +1759,8 @@ out:
error_propagate(errp, local_err);
}
-static void pc_dimm_unplug(HotplugHandler *hotplug_dev,
- DeviceState *dev, Error **errp)
+static void pc_memory_unplug(HotplugHandler *hotplug_dev,
+ DeviceState *dev, Error **errp)
{
PCMachineState *pcms = PC_MACHINE(hotplug_dev);
HotplugHandlerClass *hhc;
@@ -2015,7 +2015,7 @@ static void pc_machine_device_plug_cb(HotplugHandler
*hotplug_dev,
DeviceState *dev, Error **errp)
{
if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) {
- pc_dimm_plug(hotplug_dev, dev, errp);
+ pc_memory_plug(hotplug_dev, dev, errp);
} else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
pc_cpu_plug(hotplug_dev, dev, errp);
}
@@ -2025,7 +2025,7 @@ static void
pc_machine_device_unplug_request_cb(HotplugHandler *hotplug_dev,
DeviceState *dev, Error **errp)
{
if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) {
- pc_dimm_unplug_request(hotplug_dev, dev, errp);
+ pc_memory_unplug_request(hotplug_dev, dev, errp);
} else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
pc_cpu_unplug_request_cb(hotplug_dev, dev, errp);
} else {
@@ -2038,7 +2038,7 @@ static void pc_machine_device_unplug_cb(HotplugHandler
*hotplug_dev,
DeviceState *dev, Error **errp)
{
if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) {
- pc_dimm_unplug(hotplug_dev, dev, errp);
+ pc_memory_unplug(hotplug_dev, dev, errp);
} else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
pc_cpu_unplug_cb(hotplug_dev, dev, errp);
} else {
--
2.17.1
- [Qemu-ppc] [PATCH v5 00/12] pc-dimm: next bunch of cleanups, David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 01/12] pc-dimm: remove leftover "struct pc_dimms_capacity", David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_*, David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*,
David Hildenbrand <=
- [Qemu-ppc] [PATCH v5 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header, David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 05/12] pc: factor out pc specific dimm checks into pc_memory_pre_plug(), David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 06/12] nvdimm: no need to overwrite get_vmstate_memory_region(), David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 09/12] nvdimm: convert "unarmed" into a static property, David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 08/12] pc-dimm: merge get_(vmstate_)memory_region(), David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 10/12] nvdimm: convert nvdimm_mr into a pointer, David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 07/12] hostmem: drop error variable from host_memory_backend_get_memory(), David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 12/12] pc-dimm: get_memory_region() will not fail after realize, David Hildenbrand, 2018/06/19
- [Qemu-ppc] [PATCH v5 11/12] nvdimm: make get_memory_region() perform checks and initialization, David Hildenbrand, 2018/06/19
- Re: [Qemu-ppc] [PATCH v5 00/12] pc-dimm: next bunch of cleanups, Paolo Bonzini, 2018/06/20