[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 1/5] spapr_cpu_core: convert last snprintf() to g_strd
From: |
Greg Kurz |
Subject: |
[Qemu-ppc] [PATCH 1/5] spapr_cpu_core: convert last snprintf() to g_strdup_printf() |
Date: |
Thu, 14 Jun 2018 23:50:11 +0200 |
User-agent: |
StGit/0.17.1-46-g6855-dirty |
Because this is the preferred practice in QEMU.
Signed-off-by: Greg Kurz <address@hidden>
---
hw/ppc/spapr_cpu_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
index 7e3a9e78d090..27602245fd55 100644
--- a/hw/ppc/spapr_cpu_core.c
+++ b/hw/ppc/spapr_cpu_core.c
@@ -190,7 +190,7 @@ static void spapr_cpu_core_realize(DeviceState *dev, Error
**errp)
sc->threads = g_new(PowerPCCPU *, cc->nr_threads);
for (i = 0; i < cc->nr_threads; i++) {
- char id[32];
+ char *id;
CPUState *cs;
PowerPCCPU *cpu;
@@ -208,8 +208,9 @@ static void spapr_cpu_core_realize(DeviceState *dev, Error
**errp)
/* Set NUMA node for the threads belonged to core */
cpu->node_id = sc->node_id;
- snprintf(id, sizeof(id), "thread[%d]", i);
+ id = g_strdup_printf("thread[%d]", i);
object_property_add_child(OBJECT(sc), id, obj, &local_err);
+ g_free(id);
if (local_err) {
goto err;
}
- [Qemu-ppc] [PATCH 0/5] spapr_cpu_core: fixes and cleanups, Greg Kurz, 2018/06/14
- [Qemu-ppc] [PATCH 1/5] spapr_cpu_core: convert last snprintf() to g_strdup_printf(),
Greg Kurz <=
- [Qemu-ppc] [PATCH 2/5] spapr_cpu_core: fix potential leak in spapr_cpu_core_realize(), Greg Kurz, 2018/06/14
- [Qemu-ppc] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path, Greg Kurz, 2018/06/14
- Re: [Qemu-ppc] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path, David Gibson, 2018/06/14
- Re: [Qemu-ppc] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path, David Gibson, 2018/06/14
- Re: [Qemu-ppc] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path, Greg Kurz, 2018/06/15
- Re: [Qemu-ppc] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path, David Gibson, 2018/06/15
- Re: [Qemu-ppc] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path, Greg Kurz, 2018/06/15
- Re: [Qemu-ppc] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path, Greg Kurz, 2018/06/15