Re: [Qemu-ppc] [QEMU-PPC] [PATCH 3/3] ppc/spapr_caps: Don't disable cap_cfpc on POWER8 by default

[Suraj Jitindar Singh]

On Tue, 2018-06-05 at 12:29 +1000, David Gibson wrote:
> On Fri, May 11, 2018 at 04:25:09PM +1000, Suraj Jitindar Singh wrote:
> > In default_caps_with_cpu() we set spapr_cap_cfpc to broken for
> > POWER8
> > processors and before.
> > 
> > Since we no longer require private l1d cache on POWER8 for this cap
> > to
> > be set to workaround change this to default to broken for POWER7
> > processors and before.
> > 
> > Signed-off-by: Suraj Jitindar Singh <address@hidden>
> 
> Reviewed-by: David Gibson <address@hidden>
> 
> But not applying for now, since IIUC it depends on the previous patch
> which I'd like some changes in.

Correct, this would fail to boot without the previous patch.

Will rework the previous patch and resend.

> 
> > ---
> >  hw/ppc/spapr_caps.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> > 
> > diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
> > index 531e145114..00e43a9ba7 100644
> > --- a/hw/ppc/spapr_caps.c
> > +++ b/hw/ppc/spapr_caps.c
> > @@ -335,14 +335,10 @@ static sPAPRCapabilities
> > default_caps_with_cpu(sPAPRMachineState *spapr,
> >  
> >      caps = smc->default_caps;
> >  
> > -    if (!ppc_check_compat(cpu, CPU_POWERPC_LOGICAL_3_00,
> > -                          0, spapr->max_compat_pvr)) {
> > -        caps.caps[SPAPR_CAP_CFPC] = SPAPR_CAP_BROKEN;
> > -    }
> > -
> >      if (!ppc_check_compat(cpu, CPU_POWERPC_LOGICAL_2_07,
> >                            0, spapr->max_compat_pvr)) {
> >          caps.caps[SPAPR_CAP_HTM] = SPAPR_CAP_OFF;
> > +        caps.caps[SPAPR_CAP_CFPC] = SPAPR_CAP_BROKEN;
> >      }
> >  
> >      if (!ppc_check_compat(cpu, CPU_POWERPC_LOGICAL_2_06_PLUS,
> 
>