[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 07/28] target/microblaze: avoid integer overflow in nex
From: |
Richard Henderson |
Subject: |
[Qemu-ppc] [PULL 07/28] target/microblaze: avoid integer overflow in next_page PC check |
Date: |
Wed, 9 May 2018 10:54:37 -0700 |
From: "Emilio G. Cota" <address@hidden>
If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.
Reviewed-by: Richard Henderson <address@hidden>
Cc: "Edgar E. Iglesias" <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/microblaze/translate.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 100883e2cc..0872dc9ded 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -1635,7 +1635,7 @@ void gen_intermediate_code(CPUState *cs, struct
TranslationBlock *tb)
uint32_t pc_start;
struct DisasContext ctx;
struct DisasContext *dc = &ctx;
- uint32_t next_page_start, org_flags;
+ uint32_t page_start, org_flags;
target_ulong npc;
int num_insns;
int max_insns;
@@ -1661,7 +1661,7 @@ void gen_intermediate_code(CPUState *cs, struct
TranslationBlock *tb)
cpu_abort(cs, "Microblaze: unaligned PC=%x\n", pc_start);
}
- next_page_start = (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE;
+ page_start = pc_start & TARGET_PAGE_MASK;
num_insns = 0;
max_insns = tb_cflags(tb) & CF_COUNT_MASK;
if (max_insns == 0) {
@@ -1747,7 +1747,7 @@ void gen_intermediate_code(CPUState *cs, struct
TranslationBlock *tb)
} while (!dc->is_jmp && !dc->cpustate_changed
&& !tcg_op_buf_full()
&& !singlestep
- && (dc->pc < next_page_start)
+ && (dc->pc - page_start < TARGET_PAGE_SIZE)
&& num_insns < max_insns);
npc = dc->pc;
--
2.17.0
- [Qemu-ppc] [PULL 00/28] Bulk target patches, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 01/28] target/riscv: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 02/28] target/cris: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 05/28] target/unicore32: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 03/28] target/lm32: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 04/28] target/xtensa: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 06/28] target/tilegx: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 07/28] target/microblaze: avoid integer overflow in next_page PC check,
Richard Henderson <=
- [Qemu-ppc] [PULL 09/28] target/s390x: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 08/28] target/arm: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 10/28] target/mips: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 11/28] translator: merge max_insns into DisasContextBase, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 12/28] target/sh4: convert to TranslatorOps, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 13/28] target/sparc: convert to DisasJumpType, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 16/28] target/mips: use lookup_and_goto_ptr on BS_STOP, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 14/28] target/sparc: convert to DisasContextBase, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 15/28] target/sparc: convert to TranslatorOps, Richard Henderson, 2018/05/09
- [Qemu-ppc] [PULL 19/28] target/mips: use *ctx for DisasContext, Richard Henderson, 2018/05/09