[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently |
Date: |
Fri, 4 May 2018 10:17:01 +1000 |
User-agent: |
Mutt/1.9.3 (2018-01-21) |
On Thu, May 03, 2018 at 10:51:42PM +0300, Michael S. Tsirkin wrote:
> Some places include kvm_ppc.h, others target/ppc/kvm_ppc.h.
> Let's be consistent.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
One of your earlier patches in this series moved to using a full
target/ppc/whatever.h for includers outside target/ppc itself. So I'm
not sure why you're standardizing on the short form here.
> ---
> hw/ppc/spapr_cpu_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> index 94afeb3..312d6ed 100644
> --- a/hw/ppc/spapr_cpu_core.c
> +++ b/hw/ppc/spapr_cpu_core.c
> @@ -15,7 +15,7 @@
> #include "qapi/error.h"
> #include "sysemu/cpus.h"
> #include "sysemu/kvm.h"
> -#include "target/ppc/kvm_ppc.h"
> +#include "kvm_ppc.h"
> #include "hw/ppc/ppc.h"
> #include "target/ppc/mmu-hash64.h"
> #include "sysemu/numa.h"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature