Re: [Qemu-ppc] [PATCH v3 03/35] ppc/xive: introduce the XiveFabric interface

[David Gibson]

On Thu, Apr 26, 2018 at 12:30:42PM +0200, Cédric Le Goater wrote:
> On 04/26/2018 05:54 AM, David Gibson wrote:
> > On Tue, Apr 24, 2018 at 11:33:11AM +0200, Cédric Le Goater wrote:
> >> On 04/24/2018 08:46 AM, David Gibson wrote:
> >>> On Mon, Apr 23, 2018 at 09:58:43AM +0200, Cédric Le Goater wrote:
> >>>> On 04/23/2018 08:46 AM, David Gibson wrote:
> >>>>> On Thu, Apr 19, 2018 at 02:42:59PM +0200, Cédric Le Goater wrote:
> >>>>>> The XiveFabric offers a simple interface, between the XiveSourve
> >>>>>> object and the device model owning the interrupt sources, to forward
> >>>>>> an event notification to the XIVE interrupt controller of the machine
> >>>>>> and if the owner is the controller, to call directly the routing
> >>>>>> sub-engine.
> >>>>>>
> >>>>>> Signed-off-by: Cédric Le Goater <address@hidden>
> >>>>>> ---
> >>>>>>  hw/intc/xive.c        | 37 ++++++++++++++++++++++++++++++++++++-
> >>>>>>  include/hw/ppc/xive.h | 25 +++++++++++++++++++++++++
> >>>>>>  2 files changed, 61 insertions(+), 1 deletion(-)
> >>>>>>
> >>>>>> diff --git a/hw/intc/xive.c b/hw/intc/xive.c
> >>>>>> index 060976077dd7..b4c3d06c1219 100644
> >>>>>> --- a/hw/intc/xive.c
> >>>>>> +++ b/hw/intc/xive.c
> >>>>>> @@ -17,6 +17,21 @@
> >>>>>>  #include "hw/ppc/xive.h"
> >>>>>>  
> >>>>>>  /*
> >>>>>> + * XIVE Fabric
> >>>>>> + */
> >>>>>> +
> >>>>>> +static void xive_fabric_route(XiveFabric *xf, int lisn)
> >>>>>> +{
> >>>>>> +
> >>>>>> +}
> >>>>>> +
> >>>>>> +static const TypeInfo xive_fabric_info = {
> >>>>>> +    .name = TYPE_XIVE_FABRIC,
> >>>>>> +    .parent = TYPE_INTERFACE,
> >>>>>> +    .class_size = sizeof(XiveFabricClass),
> >>>>>> +};
> >>>>>> +
> >>>>>> +/*
> >>>>>>   * XIVE Interrupt Source
> >>>>>>   */
> >>>>>>  
> >>>>>> @@ -97,11 +112,19 @@ static bool xive_source_pq_trigger(XiveSource 
> >>>>>> *xsrc, uint32_t srcno)
> >>>>>>  
> >>>>>>  /*
> >>>>>>   * Forward the source event notification to the associated XiveFabric,
> >>>>>> - * the device owning the sources.
> >>>>>> + * the device owning the sources, or perform the routing if the device
> >>>>>> + * is the interrupt controller.
> >>>>>>   */
> >>>>>>  static void xive_source_notify(XiveSource *xsrc, int srcno)
> >>>>>>  {
> >>>>>>  
> >>>>>> +    XiveFabricClass *xfc = XIVE_FABRIC_GET_CLASS(xsrc->xive);
> >>>>>> +
> >>>>>> +    if (xfc->notify) {
> >>>>>> +        xfc->notify(xsrc->xive, srcno + xsrc->offset);
> >>>>>> +    } else {
> >>>>>> +        xive_fabric_route(xsrc->xive, srcno + xsrc->offset);
> >>>>>> +    }
> >>>>>
> >>>>> Why 2 cases?  Can't the XiveFabric object just make its notify equal
> >>>>> to xive_fabric_route if that's what it wants?
> >>>> Under sPAPR, all the sources, IPIs and virtual device interrupts, 
> >>>> generate events which are directly routed by xive_fabric_route(). 
> >>>> There is no need of an extra hop. Indeed. 
> >>>
> >>> Ok.
> >>>
> >>>> Under PowerNV, some sources forward the notification to the routing 
> >>>> engine using a specific MMIO load on a notify address which is stored 
> >>>> in one of the controller registers. So we need a hop to reach the 
> >>>> device model, owning the sources, and do that load :
> >>>
> >>> Hm.  So you're saying that in pnv some sources send their notification
> >>> to some other unit, 
> >>
> >> Not to any unit/device, to the device owning the sources.
> >>
> >> For the XiveSource object under PSI, the XIVEFabric interface is the 
> >> PSI device object it self, which knows how to forward the notification 
> >> on the XIVE Power "bus". To be more precise, the PSI HB device has 
> >> 14 interrupt sources, which notifications are forwarded using a MMIO 
> >> load to some address. The load address is configured (by skiboot) in 
> >> one of the PSI device registers, and points to a MMIO region of the 
> >> main XIVE interrupt controller. 
> >>
> >> The PHB4 sources should be the same.
> >>
> >> For the XiveSource object (all interrupts) under sPAPRXive, the 
> >> XIVEFabric is the main interrupt controller sPAPRXive.
> >>
> >> For the XiveSource object (IPIs) under PnvXive, the XIVEFabric is 
> >> also the main interrupt controller PnvXive.
> > 
> > Hrm.  Apparently I'm missing something, I'm really not getting what
> > you're trying to explain here.
> 
> I see that. Let's try again.
> 
> >>> that would then (after possible masking) forward on to the overall> xive 
> >>> fabric ? 
> >>
> >> yes. May be XIVEFabric is a confusing name. What about XIVEForwarder ? 
> > 
> > Maybe..?
> > 
> >>> That seems like a property of the source object, 
> >>
> >> The source object is generic. It's a bunch of PQ bits that can be 
> >> controlled by MMIOs. Nothing more.
> > 
> > Hmm.  Isn't the source object also responsible for forwarding the
> > interrupt to something up the chain (whatever that is)?
> 
> Yes but it can not forward directly. The XiveSource is generic and 
> can only call a handler :
> 
>       xfc->notify(xsrc->xive, srcno + xsrc->offset);

But.. your patch doesn't do that always, it's conditional which I
still don't understand.

> The device model owner, the parent of the XiveSource object, would 
> do the real forward.

Why?  I mean the XiveSource basically represents the xive irq related
logic of the PHB or whatever, why would it not represent *all* of
that, rather than just the ESB bits, meaning the owner has to have
some more xive logic for the forwarding.

Note that I don't think the fact that some sources notify via mmio and
some are internal really matters.  It's not like we're modelling the
power bus down to the wire-transaction level.

> It's very similar to what we have today with XICS :
> 
>       - The sPAPR model has an ICSState  
>       - The PnvPSI model has an ICSState 
>       - The PnvPHB3 model has two ICSStates
> 
> and the 'xics' pointer in ICSState points to the 'interrupt unit' of 
> the machine to do resends and to grab ICPs. So it used for routing 
> essentially.

Hmm.  I think you and I are looking at XICSFabric kind of
differently.  As I see it, it's not really an active component at
all.  Rather it's basically a global "map" of the xics components so
that they can find each other.

> in Xive 
> 
>       - sPAPRXive model has a XiveSource
>       - PnvXive model has a XiveSource
>       - PnvPSI model has a XiveSource
>       - PnvPHB4 model should have also.
> 
> and the 'xive' pointer in XiveSource points to the parent object,

Uh.. yeah.. the xics pointer in ICS units doesn't point to the parent
object, except maybe by accident.  It's absolutely intended to be
global, and so points to the machine.

> which will handle the event notification forwarding or routing.

Ok, how about this for a partial model.  We have:

XiveSource objects:
        * Owns an ESB table
        * Knows the mapping of its local irq offsets to global irq
          numbers
        * Provides the mmio interface for ESB manipulation
        * When neccessary, notifies a new interrupt to a XiveRouter

XiveRouter objects:
        * Responsible for a fixed range of global irq numbers
        * Owns an IVT (but what that means can vary, see below)
        * When notified of an irq, routes it to the appropriate EQ
          (haven't thought about this part yet)
        * Abstract class - needs subclasses to define how to get IVEs

XiveFabric interface:
        * Lets XIVE components locate each other
        * get_router() method: maps a global irq number to XiveRouter
          object
        * Always global (implemented on the machine)

On pseries we have:

        ? XiveSource objects.  We probably only need one, but 1 for
        LSI and one for MSI might be convenient.  More wouldn't break
        the model

        1 sPAPRXiveRouter.  This is a subclass of XiveRouter that
        holds the IVT internall (and migrates it).

        the XiveFabric implementation always returns the single global
        router for get_router()

On powernv we have:
        N XiveSource objects.  Some in PHBs, some extra ones on each
        chip

        (#chips) PowerXiveRouter objects.  This subclass of XiveRouter
        stores the register giving the IVT base address and migrates
        that, but the IVT contents are in RAM

        the XiveFabric get_router() implementation returns the right
        chip's router based on the irq number

Obviously the router->EQ sides still needs a bunch of thought.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature