Re: [Qemu-ppc] ppc440_pcix_reg warnings with the new sam460ex board

[BALATON Zoltan]

Hello,

On Wed, 7 Mar 2018, Thomas Huth wrote:
> I was just trying to add a regression qtest for the new sam460ex board,
> but I noticed that there are currently some ugly warnings showing up
> when using this board:
>
> qemu-system-ppc: ppc440_pcix_reg_write4: unhandled PCI internal register 0x40
> qemu-system-ppc: ppc440_pcix_reg_read4: invalid PCI internal register 0x44
> qemu-system-ppc: ppc440_pcix_reg_write4: unhandled PCI internal register 0x44
>
> Are you aware of these warning messages? Could they be silenced somehow?

I don't know what these registers are and how to implement them properly 
but I've sent a patch that adds dummy implementations that silences these 
warnings if that helps. But why are these warnings cause a problem for 
tests?

> FWIW, here's what I wanted to add to the qtest suite:
>
> diff a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -79,12 +79,14 @@ static testdef_t tests[] = {
>     { "ppc", "40p", "-boot d", "Booting from device d" },
>     { "ppc", "g3beige", "", "PowerPC,750" },
>     { "ppc", "mac99", "", "PowerPC,G4" },
> +    { "ppc", "sam460ex", "-m 256", "DRAM:  256 MiB" },
>     { "ppc64", "ppce500", "", "U-Boot" },
>     { "ppc64", "prep", "-boot e", "Booting from device e" },
>     { "ppc64", "40p", "-m 192", "Memory size: 192 MB" },
>     { "ppc64", "mac99", "", "PowerPC,970FX" },
>     { "ppc64", "pseries", "", "Open Firmware" },
>     { "ppc64", "powernv", "-cpu POWER8", "OPAL" },
> +    { "ppc64", "sam460ex", "-device e1000", "8086  100e" },

Why are you using random command line options (like -m and -device) 
instead of just running the default config without options and looking for 
something like "Board: Sam460ex" in the output which is printed by 
default? That looks more straight forward to me. Or if you want to test 
most of the devices you could look for "SM502: found" which is one of the 
last lines printed on serial during boot after probing for most hardware 
so that should also catch errors in some device emulation if it does not 
get to that but breaks before.

Also does it make sense to test both with ppc and ppc64 when the two 
should be identical? Like for g3beige (and unlike for mac99) the sam460ex 
is only a 32bit board so probably testing with ppc64 does not really make 
sense and only ppc should be added?

Regards,
BALATON Zoltan

>     { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
>     { "i386", "pc", "-device sga", "SGABIOS" },
>     { "i386", "q35", "-device sga", "SGABIOS" },
>
> Thomas