[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h> |
Date: |
Sun, 21 Jan 2018 20:44:19 +1100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Jan 19, 2018 at 09:15:11AM +0100, Cédric Le Goater wrote:
> This redefinition generates warnings on some clang compilers and older
> gcc4.4.
>
> ...include/hw/ppc/pnv_xscom.h:24:24: warning: redefinition of typedef
> 'PnvChip' is a C11
> feature [-Wtypedef-redefinition]
> typedef struct PnvChip PnvChip;
> ^
> ...include/hw/ppc/pnv.h:65:3: note: previous definition is here
> } PnvChip;
> ^
> 1 warning generated.
> CC ppc64-softmmu/hw/ppc/pnv_xscom.o
>
> Signed-off-by: Cédric Le Goater <address@hidden>
Applied, thanks.
> ---
> include/hw/ppc/pnv_xscom.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index fb1bd5df095a..255b26a5aaf6 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -21,8 +21,6 @@
>
> #include "qom/object.h"
>
> -typedef struct PnvChip PnvChip;
> -
> typedef struct PnvXScomInterface {
> Object parent;
> } PnvXScomInterface;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature