Re: [Qemu-ppc] [RFC for-2.12 5/8] spapr: Assume msi_nonbroken

[Alexey Kardashevskiy]

On 11/12/17 18:08, David Gibson wrote:
> We conditionally adjust part of the guest device tree based on the
> global msi_nonbroken flag.  However, the main machine type code
> initializes msi_nonbroken to true and there's nothing that would set
> it to false again.
> 
> So replace the test with an assert().

Reviewed-by: Alexey Kardashevskiy <address@hidden>

This does not really belong to the series.


> 
> Signed-off-by: David Gibson <address@hidden>
> ---
>  hw/ppc/spapr.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 4e4cf35587..e206825ed9 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -944,9 +944,8 @@ static void spapr_dt_rtas(sPAPRMachineState *spapr, void 
> *fdt)
>      _FDT(fdt_setprop_cell(fdt, rtas, "rtas-event-scan-rate",
>                            RTAS_EVENT_SCAN_RATE));
>  
> -    if (msi_nonbroken) {
> -        _FDT(fdt_setprop(fdt, rtas, "ibm,change-msix-capable", NULL, 0));
> -    }
> +    g_assert(msi_nonbroken);
> +    _FDT(fdt_setprop(fdt, rtas, "ibm,change-msix-capable", NULL, 0));
>  
>      /*
>       * According to PAPR, rtas ibm,os-term does not guarantee a return
> 


-- 
Alexey