[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 0/3] ppc: fix memory leaks
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 0/3] ppc: fix memory leaks |
Date: |
Wed, 7 Jun 2017 09:45:06 +1000 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jun 06, 2017 at 05:22:42PM +0200, Greg Kurz wrote:
> Coverity just reported a memory leak introduced by this commit (QEMU 2.9):
>
> commit df58713396f8b2deb923e39c00b10744c5c63909
> Author: Thomas Huth <address@hidden>
> Date: Wed Feb 15 10:21:44 2017 +0100
>
> hw/ppc/spapr: Check for valid page size when hot plugging memory
>
> It boils down to the fact that object_property_get_str() returns a string
> allocated with g_strdup(), which must be deallocated with g_free() at some
> point.
Applied to ppc-for-2.10. Do we need to queue this for 2.9 stable as
well?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH v2] target/ppc: pass const string to kvmppc_is_mem_backend_page_size_ok(), (continued)