[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/4] spapr: Move DRC RTAS calls into
From: |
Michael Roth |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/4] spapr: Move DRC RTAS calls into spapr_drc.c |
Date: |
Thu, 01 Jun 2017 10:56:50 -0500 |
User-agent: |
alot/0.5.1 |
Quoting David Gibson (2017-05-31 20:52:15)
> Currently implementations of the RTAS calls related to DRCs are in
> spapr_rtas.c. They belong better in spapr_drc.c - that way they're closer
> to related code, and we'll be able to make some more things local.
>
> spapr_rtas.c was intended to contain the RTAS infrastructure and core calls
> that don't belong anywhere else, not every RTAS implementation.
>
> Code motion only.
Technically rtas-get-sensor-state and rtas-set-indicator aren't specific
to DRCs, but looking through the documented indicators/sensors (tables
40 and 42 in LoPAPR v11) it doesn't seem too likely we'll ever implement
any others so the move seems reasonable.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/ppc/spapr_drc.c | 322
> ++++++++++++++++++++++++++++++++++++++++++++++++++--
> hw/ppc/spapr_rtas.c | 304 -------------------------------------------------
> 2 files changed, 315 insertions(+), 311 deletions(-)
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/4] spapr: Move DRC RTAS calls into spapr_drc.c,
Michael Roth <=