[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] fixup! sysbus: Set user_creatable=false by defaul
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-ppc] [PATCH] fixup! sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE |
Date: |
Mon, 8 May 2017 12:51:58 +0200 |
On Fri, 5 May 2017 17:36:20 -0300
Eduardo Habkost <address@hidden> wrote:
> Fixup will be included in v3, or can be applied by maintainer:
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> hw/core/sysbus.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
> index 6a2eec8dd0..5d0887f499 100644
> --- a/hw/core/sysbus.c
> +++ b/hw/core/sysbus.c
> @@ -327,14 +327,14 @@ static void sysbus_device_class_init(ObjectClass
> *klass, void *data)
> k->init = sysbus_device_init;
> k->bus_type = TYPE_SYSTEM_BUS;
> /*
> - * device_add plugs devices into suitable bus. For "real" buses,
> + * device_add plugs devices into a suitable bus. For "real" buses,
> * that actually connects the device. For sysbus, the connections
> * need to be made separately, and device_add can't do that. The
> * device would be left unconnected, and will probably not work
> *
> - * However, a few machines and a few devices can handle a few sysbus
> - * devices. In this case, the device subclass needs to override
> - * it and set user_creatable=true.
> + * However, a few machines can handle device_add/-device with
> + * a few specific sysbus devices. In those cases, the device
> + * subclass needs to override it and set user_creatable=true.
> */
> k->user_creatable = false;
> }
FWIW: LGTM