Re: [Qemu-ppc] [PATCH v4 1/8] spapr: Add ibm, processor-radix-AP-encodings to the device tree

[David Gibson]

On Thu, Mar 16, 2017 at 05:08:13PM +1100, Sam Bobroff wrote:
> Use the new ioctl, KVM_PPC_GET_RMMU_INFO, to fetch radix MMU
> information from KVM and present the page encodings in the device tree
> under ibm,processor-radix-AP-encodings. This provides page size
> information to the guest which is necessary for it to use radix mode.
> 
> Signed-off-by: Sam Bobroff <address@hidden>

Reviewed-by: David Gibson <address@hidden>

..with the exception of one nit..

[snip]
>  static bool kvm_valid_page_size(uint32_t flags, long rampgsize, uint32_t 
> shift)
>  {
>      if (!(flags & KVM_PPC_PAGE_SIZES_REAL)) {
> @@ -2306,6 +2331,10 @@ static void kvmppc_host_cpu_class_init(ObjectClass 
> *oc, void *data)
>          pcc->l1_icache_size = icache_size;
>      }
>  
> +    if (kvm_enabled()) {

You don't need this - this function is only called in the KVM accel
case anyway.

> +        pcc->radix_page_info = kvm_get_radix_page_info();
> +    }
> +
>      /* Reason: kvmppc_host_cpu_initfn() dies when !kvm_enabled() */
>      dc->cannot_destroy_with_object_finalize_yet = true;
>  }

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature