[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 04/49] tests: don't check if qtest_spapr_boot() returns
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 04/49] tests: don't check if qtest_spapr_boot() returns NULL |
Date: |
Wed, 26 Oct 2016 22:42:08 +1100 |
From: Laurent Vivier <address@hidden>
qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot()
and qtest_vboot() calls g_malloc(),
and g_malloc() never fails:
if memory allocation fails, the application is terminated.
Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
tests/libqos/libqos.c | 2 ++
tests/rtas-test.c | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c
index 7abb482..6226546 100644
--- a/tests/libqos/libqos.c
+++ b/tests/libqos/libqos.c
@@ -10,6 +10,8 @@
/**
* Launch QEMU with the given command line,
* and then set up interrupts and our guest malloc interface.
+ * Never returns NULL:
+ * Terminates the application in case an error is encountered.
*/
QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap)
{
diff --git a/tests/rtas-test.c b/tests/rtas-test.c
index ba0867a..276c87e 100644
--- a/tests/rtas-test.c
+++ b/tests/rtas-test.c
@@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void)
time_t t1, t2;
qs = qtest_spapr_boot("-machine pseries");
- g_assert(qs != NULL);
t1 = time(NULL);
ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns);
--
2.7.4
- [Qemu-ppc] [PULL 00/49] ppc-for-2.8 queue 20161026, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 04/49] tests: don't check if qtest_spapr_boot() returns NULL,
David Gibson <=
- [Qemu-ppc] [PULL 02/49] ppc/xics: Add xics to the monitor "info pic" command, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 03/49] tests: fix memory leak in virtio-scsi-test, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 09/49] spapr_pci: advertise explicit numa IDs even when there's 1 node, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 19/49] ppc: fix MSR_ME handling for system reset interrupt, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 10/49] nvram: Introduce helper functions for CHRP "system" and "free space" partitions, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 06/49] tests: rename target_big_endian() as qvirtio_is_big_endian(), David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 08/49] tests: enable virtio tests on SPAPR, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 21/49] ppc: Fix single step with gdb stub, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 11/49] sparc: Use the new common NVRAM functions for system and free space partition, David Gibson, 2016/10/26
- [Qemu-ppc] [PULL 14/49] target-ppc: implement vnegw/d instructions, David Gibson, 2016/10/26