[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 02/11] spapr_hcall: use spapr_ovec_* interfaces fo
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-ppc] [PATCH 02/11] spapr_hcall: use spapr_ovec_* interfaces for CAS options |
|
Date: |
Fri, 14 Oct 2016 12:40:34 +0530 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Oct 12, 2016 at 06:13:50PM -0500, Michael Roth wrote:
> Currently we access individual bytes of an option vector via
> ldub_phys() to test for the presence of a particular capability
> within that byte. Currently this is only done for the "dynamic
> reconfiguration memory" capability bit. If that bit is present,
> we pass a boolean value to spapr_h_cas_compose_response()
> to generate a modified device tree segment with the additional
> properties required to enable this functionality.
>
> As more capability bits are added, will would need to modify the
> code to add additional option vector accesses and extend the
> param list for spapr_h_cas_compose_response() to include similar
> boolean values for these parameters.
>
> Avoid this by switching to spapr_ovec_* helpers so we can do all
> the parsing in one shot and then test for these additional bits
> within spapr_h_cas_compose_response() directly.
>
> Cc: Bharata B Rao <address@hidden>
> Signed-off-by: Michael Roth <address@hidden>
Nicely done!
Reviewed-by: Bharata B Rao <address@hidden>
Regards,
Bharata.
- [Qemu-ppc] [RFC PATCH 00/11] spapr: option vector re-work and memory unplug support, Michael Roth, 2016/10/12
- [Qemu-ppc] [PATCH 10/11] spapr: use count+index for memory hotplug, Michael Roth, 2016/10/12
- [Qemu-ppc] [PATCH 09/11] spapr: Add DRC count indexed hotplug identifier type, Michael Roth, 2016/10/12
- [Qemu-ppc] [PATCH 11/11] spapr: Memory hot-unplug support, Michael Roth, 2016/10/12
- [Qemu-ppc] [PATCH 02/11] spapr_hcall: use spapr_ovec_* interfaces for CAS options, Michael Roth, 2016/10/12
- [Qemu-ppc] [PATCH 07/11] spapr: add hotplug interrupt machine options, Michael Roth, 2016/10/12
- [Qemu-ppc] [PATCH 06/11] spapr: update spapr hotplug documentation, Michael Roth, 2016/10/12
- [Qemu-ppc] [PATCH 03/11] spapr: add option vector handling in CAS-generated resets, Michael Roth, 2016/10/12