Re: [Qemu-ppc] [PATCH v3 10/10] ppc/pnv: add a ISA bus

[David Gibson]

On Thu, Sep 22, 2016 at 10:44:13AM +0200, Cédric Le Goater wrote:
> 
> >> +static ISABus *pnv_isa_create(PnvChip *chip)
> >> +{
> >> +    PnvLpcController *lpc = &chip->lpc;
> >> +    ISABus *isa_bus;
> >> +    qemu_irq *irqs;
> >> +    PnvChipClass *pcc = PNV_CHIP_GET_CLASS(chip);
> >> +
> >> +    /* Instanciate ISA bus. let isa_bus_new() create its own bridge on
> > 
> > Instantiate has 3 't's and no 'c's; English orthography strikes again.
> 
> he :) thanks. 
> 
> >> +     * sysbus otherwise devices speficied on the command line will
> >> +     * fail to create.
> >> +     */
> >> +    isa_bus = isa_bus_new(NULL, &lpc->isa_mem, &lpc->isa_io,
> >> +                          &error_fatal);
> > 
> > It's not clear to me if this belongs in the chip code or on the lpc
> > code - the lpc does create a device node as 'isa@', although it also
> > does some other stuff.
> 
> In fact, the isabus in the qemu model is at the machine level, see below,
> next to the 'Instanc^Htiate'.
> 
> each chip has a lpc controller but skiboot use a default one to route
> the traffic. So we choose the chip[0] one for that. 
> 
> Looking closer, I should make sure the "primary" cell is not added in the 
> device tree for chip_id != 0.

Ok, that seens sensible.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature