[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 05/10] ppc/pnv: add a PnvCore object
|
From: |
Benjamin Herrenschmidt |
|
Subject: |
Re: [Qemu-ppc] [PATCH v3 05/10] ppc/pnv: add a PnvCore object |
|
Date: |
Wed, 21 Sep 2016 12:05:47 +1000 |
On Wed, 2016-09-21 at 11:51 +1000, David Gibson wrote:
> Ok, as noted elsewhere, I think you need to disassociate the PIR value
> from the cpu_index. It may be a little less elegant, but it'll make
> your life much easier in the short and medium term.
>
> Apart from that, this looks pretty good, though I have one suggested
> cleanup below.
As long as the PIR value is what is used everywhere, ie, interrupt
controller, XSCOM addressing of the cores, Doorbells, etc...
Cheers,
Ben.