[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 5/5] spapr_vscsi: convert to trace fr
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF |
|
Date: |
Wed, 14 Sep 2016 21:56:47 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 14.09.2016 20:48, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> hw/scsi/spapr_vscsi.c | 89
> +++++++++++++++++++++------------------------------
> hw/scsi/trace-events | 27 ++++++++++++++++
> 2 files changed, 63 insertions(+), 53 deletions(-)
>
> diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
> index 8fbd50f..29fef90 100644
> --- a/hw/scsi/spapr_vscsi.c
> +++ b/hw/scsi/spapr_vscsi.c
While you're at it: There is a stray fprintf statement at the beginning
of vscsi_process_tsk_mgmt() which is rather a debug statement than
really something that should be printed always ... could you please turn
that into a trace event, too?
Thanks,
Thomas
signature.asc
Description: OpenPGP digital signature
- [Qemu-ppc] [PATCH 0/5] spapr: convert SPAPR devices to trace framework, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 3/5] spapr_vio: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 4/5] spapr_llan: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- Re: [Qemu-ppc] [PATCH 0/5] spapr: convert SPAPR devices to trace framework, David Gibson, 2016/09/14