[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v3 09/10] gdbstub: Convert target_memory_rw_debug to u
From: |
Andrey Smirnov |
Subject: |
[Qemu-ppc] [PATCH v3 09/10] gdbstub: Convert target_memory_rw_debug to use MemoryAccessType |
Date: |
Tue, 19 Jul 2016 22:02:59 -0700 |
Convert target_memory_rw_debug to use MemoryAccessType as to follow
similar conversion of cpu_memory_rw_debug.
Signed-off-by: Andrey Smirnov <address@hidden>
---
gdbstub.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 9c4cbe4..c215672 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -44,15 +44,17 @@
#endif
static inline int target_memory_rw_debug(CPUState *cpu, target_ulong addr,
- uint8_t *buf, int len, bool is_write)
+ uint8_t *buf, int len,
+ MemoryAccessType access_type)
{
CPUClass *cc = CPU_GET_CLASS(cpu);
if (cc->memory_rw_debug) {
+ const bool is_write = (access_type == MEM_DATA_STORE);
return cc->memory_rw_debug(cpu, addr, buf, len, is_write);
}
- return cpu_memory_rw_debug(cpu, addr, buf, len,
- is_write ? MEM_DATA_STORE : MEM_DATA_LOAD);
+
+ return cpu_memory_rw_debug(cpu, addr, buf, len, access_type);
}
enum {
@@ -966,7 +968,8 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
break;
}
- if (target_memory_rw_debug(s->g_cpu, addr, mem_buf, len, false) != 0) {
+ if (target_memory_rw_debug(s->g_cpu, addr, mem_buf,
+ len, MEM_DATA_LOAD) != 0) {
put_packet (s, "E14");
} else {
memtohex(buf, mem_buf, len);
@@ -988,7 +991,7 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
}
hextomem(mem_buf, p, len);
if (target_memory_rw_debug(s->g_cpu, addr, mem_buf, len,
- true) != 0) {
+ MEM_DATA_STORE) != 0) {
put_packet(s, "E14");
} else {
put_packet(s, "OK");
--
2.5.5
- [Qemu-ppc] [PATCH v3 00/10] Support non-direct memory writes in cpu_memory_rw_debug, Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 04/10] address_space_write_continue: Distill common code, Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 02/10] Change signature of address_space_read() to avoid casting, Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 03/10] Change signature of address_space_write() to avoid casting, Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 01/10] Avoid needless calls to address_space_rw(), Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 08/10] Convert address_space_rw to use MemoryAccessType, Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 09/10] gdbstub: Convert target_memory_rw_debug to use MemoryAccessType,
Andrey Smirnov <=
- [Qemu-ppc] [PATCH v3 10/10] exec: Use address_space_rw to handle reads and wirtes, Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 07/10] Convert cpu_memory_rw_debug to use MemoryAccessType, Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 05/10] Rename MMUAccessType to MemoryAccessType, Andrey Smirnov, 2016/07/20
- [Qemu-ppc] [PATCH v3 06/10] Change signature of cpu_memory_rw_debug() to avoid casting, Andrey Smirnov, 2016/07/20