[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PULL 07/14] vfio/spapr: Create DMA window dynamically (S
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PULL 07/14] vfio/spapr: Create DMA window dynamically (SPAPR IOMMU v2) |
Date: |
Tue, 12 Jul 2016 15:26:17 +1000 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, Jul 11, 2016 at 03:51:44PM +0200, Paolo Bonzini wrote:
>
>
> On 05/07/2016 07:31, David Gibson wrote:
> > + ret = ioctl(container->fd, VFIO_IOMMU_SPAPR_TCE_CREATE, &create);
> > + if (ret) {
> > + error_report("Failed to create a window, ret = %d (%m)", ret);
> > + return -errno;
> > + }
> > +
> > + if (create.start_addr != section->offset_within_address_space) {
> > + vfio_spapr_remove_window(container, create.start_addr);
> > +
> > + error_report("Host doesn't support DMA window at %"HWADDR_PRIx",
> > must be %"PRIx64,
> > + section->offset_within_address_space,
> > + (uint64_t)create.start_addr);
> > + ioctl(container->fd, VFIO_IOMMU_SPAPR_TCE_REMOVE, &remove);
>
> Was this ioctl left there by mistake? It passes the address of the
> remove *function* to VFIO_IOMMU_SPAPR_TCE_REMOVE.
Heh, good catch. I've posted a fix for this.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PULL 11/14] target-ppc: Simplify HPTE matching, (continued)
- [Qemu-ppc] [PULL 11/14] target-ppc: Simplify HPTE matching, David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 06/14] vfio: Add host side DMA window capabilities, David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 14/14] ppc/hash64: Fix support for LPCR:ISL, David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 02/14] spapr: Ensure thread0 of CPU core is always realized first, David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 01/14] ppc: Fix xsrdpi, xvrdpi and xvrspi rounding, David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 09/14] ppc: simplify ppc_hash64_hpte_page_shift_noslb(), David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 10/14] target-ppc: Correct page size decoding in ppc_hash64_pteg_search(), David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 04/14] spapr_iommu: Realloc guest visible TCE table when starting/stopping listening, David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 07/14] vfio/spapr: Create DMA window dynamically (SPAPR IOMMU v2), David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 13/14] ppc/hash64: Add proper real mode translation support, David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 05/14] vfio: spapr: Add DMA memory preregistering (SPAPR IOMMU v2), David Gibson, 2016/07/05
- [Qemu-ppc] [PULL 08/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW), David Gibson, 2016/07/05
- Re: [Qemu-ppc] [PULL 00/14] ppc-for-2.7 queue 20160705 (v2), Peter Maydell, 2016/07/05