[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v1 01/11] ppc/xics: Rename existing xics to xics_s
|
From: |
Nikunj A Dadhania |
|
Subject: |
Re: [Qemu-ppc] [PATCH v1 01/11] ppc/xics: Rename existing xics to xics_spapr |
|
Date: |
Fri, 24 Jun 2016 11:23:52 +0530 |
|
User-agent: |
Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) |
David Gibson <address@hidden> writes:
> diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
>> index 9091054..452a978 100644
>> --- a/include/hw/ppc/xics.h
>> +++ b/include/hw/ppc/xics.h
>> @@ -32,20 +32,24 @@
>> #define TYPE_XICS_COMMON "xics-common"
>> #define XICS_COMMON(obj) OBJECT_CHECK(XICSState, (obj), TYPE_XICS_COMMON)
>>
>> -#define TYPE_XICS "xics"
>> -#define XICS(obj) OBJECT_CHECK(XICSState, (obj), TYPE_XICS)
>> +/*
>> + * Retain xics as the type name to be compatible for migration. Rest all the
>> + * functions, class and variables are renamed as xics_spapr.
>> + */
>> +#define TYPE_XICS_SPAPR "xics"
>> +#define XICS(obj) OBJECT_CHECK(XICSState, (obj), TYPE_XICS_SPAPR)
>
> This should change to XICS_SPAPR to match the TYPE macro.
Done.
>
>>
>> -#define TYPE_KVM_XICS "xics-kvm"
>> -#define KVM_XICS(obj) OBJECT_CHECK(KVMXICSState, (obj), TYPE_KVM_XICS)
>> +#define TYPE_XICS_SPAPR_KVM "xics-spapr-kvm"
>> +#define KVM_XICS(obj) OBJECT_CHECK(KVMXICSState, (obj), TYPE_XICS_SPAPR_KVM)
>
> Likewise XICS_SPAPR_KVM().
>
Done.
Regards
Nikunj