[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] target-ppc: ppce500_spin.c uses SPR_PIR, should u
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH] target-ppc: ppce500_spin.c uses SPR_PIR, should use SPR_BOOKE_PIR |
Date: |
Fri, 24 Jun 2016 12:27:41 +1000 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, Jun 23, 2016 at 03:35:17PM -0700, Aaron Larson wrote:
>
> ppce500_spin.c uses SPR_PIR to initialize the spin table, however on
> Book E processors the correct SPR is SPR_BOOKE_PIR.
>
> Signed-off-by: Aaron Larson <address@hidden>
Applied to ppc-for-2.7, thanks.
IIRC this leaves a redundant bit in spin_init, but that can be cleaned
up later.
> ---
> hw/ppc/ppce500_spin.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/ppce500_spin.c b/hw/ppc/ppce500_spin.c
> index 76bd78b..225177b 100644
> --- a/hw/ppc/ppce500_spin.c
> +++ b/hw/ppc/ppce500_spin.c
> @@ -104,7 +104,7 @@ static void spin_kick(void *data)
> hwaddr map_start;
>
> cpu_synchronize_state(cpu);
> - stl_p(&curspin->pir, env->spr[SPR_PIR]);
> + stl_p(&curspin->pir, env->spr[SPR_BOOKE_PIR]);
> env->nip = ldq_p(&curspin->addr) & (map_size - 1);
> env->gpr[3] = ldq_p(&curspin->r3);
> env->gpr[4] = 0;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature