[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate i
From: |
Anton Blanchard |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate |
Date: |
Sat, 18 Jun 2016 14:02:46 +1000 |
Hi,
> > > Bother. I've tentatively put a revert into ppc-for-2.7. Richard,
> > > do you have a better idea how to fix it?
> >
> > Please try the following.
>
> Thanks! This passes my tests. Feel free to add:
>
> Tested-by: Anton Blanchard <address@hidden>
Actually I think I've found a problem:
lis r4,address@hidden
ori r4,r4,address@hidden
rlwinm r3,r4,0,25,1
32 bit rotate is defined as a 64 bit rotate of 2 copies of the 32 bit
value, so we expect 0x7fffffff4000007f, but get 0x4000007f.
Not sure if anything out there depends on it though.
Anton
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate, Anton Blanchard, 2016/06/15
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate, David Gibson, 2016/06/16
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate, Richard Henderson, 2016/06/16
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate, Anton Blanchard, 2016/06/17
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate,
Anton Blanchard <=
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate, Richard Henderson, 2016/06/18
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate, Thomas Huth, 2016/06/20
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate, Peter Maydell, 2016/06/20
- Re: [Qemu-ppc] [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate, Thomas Huth, 2016/06/20