Re: [Qemu-ppc] [PATCH] vfio: Fix broken EEH

[David Gibson]

On Wed, Jun 15, 2016 at 02:46:23PM +1000, David Gibson wrote:
> On Wed, Jun 15, 2016 at 02:28:27PM +1000, Gavin Shan wrote:
> > vfio_eeh_container_op() is the backend that communicates with
> > host kernel to support EEH functionality in QEMU. However, the
> > functon should return the value from host kernel instead of 0
> > unconditionally.
> > 
> > Signed-off-by: Gavin Shan <address@hidden>
> 
> Applied to ppc-for-2.7, thanks.

Hang on, wait.. forgot I should get an ack for this from you, Alex.
I'll keep it in my tree for now, unless you tell me you'd prefer to
take it through yours.

> 
> We should probably look at applying this to the 2.6 stable branch as well.
> 
> > ---
> >  hw/vfio/common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> > index e51ed3a..e51db46 100644
> > --- a/hw/vfio/common.c
> > +++ b/hw/vfio/common.c
> > @@ -1258,7 +1258,7 @@ static int vfio_eeh_container_op(VFIOContainer 
> > *container, uint32_t op)
> >          return -errno;
> >      }
> >  
> > -    return 0;
> > +    return ret;
> >  }
> >  
> >  static VFIOContainer *vfio_eeh_as_container(AddressSpace *as)
> 



-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature