[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce Hotplug
|
From: |
Igor Mammedov |
|
Subject: |
Re: [Qemu-ppc] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback |
|
Date: |
Fri, 3 Jun 2016 11:23:13 +0200 |
On Fri, 3 Jun 2016 15:10:45 +1000
David Gibson <address@hidden> wrote:
> On Thu, Jun 02, 2016 at 11:32:13AM +0200, Igor Mammedov wrote:
> > On Thu, 2 Jun 2016 11:15:44 +1000
> > David Gibson <address@hidden> wrote:
> >
> > > On Thu, May 12, 2016 at 09:18:15AM +0530, Bharata B Rao wrote:
> > > > From: Igor Mammedov <address@hidden>
> > > >
> > > > pre_plug callback is to be called before device.realize() is
> > > > executed. This would allow to check/set device's properties from
> > > > HotplugHandler.
> > > >
> > > > Signed-off-by: Igor Mammedov <address@hidden>
> > > > Signed-off-by: Bharata B Rao <address@hidden>
> > > > Reviewed-by: David Gibson <address@hidden>
> > >
> > > Igor, do you think we're ready to merge this?
> > Yes, I think so.
> >
> > >
> > > If so, do you want to take it through your tree, or should I take it
> > > through the ppc tree?
> > Please take it through your tree, along with the rest patches
> > in this series.
>
> Ok, I've made a branch to collate these into, see:
> https://github.com/dgibson/qemu/tree/ppc-cpu-hotplug
Great, thanks!
Looks ok to me.
>
> For now just patches 5&6 are there (not ppc specific), but I plan to
> merge in the rest as I review them.
>