[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v7 10/13] spapr: CPU hotplug support
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v7 10/13] spapr: CPU hotplug support |
Date: |
Mon, 1 Feb 2016 14:07:30 +1100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Jan 28, 2016 at 11:19:52AM +0530, Bharata B Rao wrote:
> Support CPU hotplug via device-add command like this:
>
> (qemu) device_add powerpc64-cpu-core,id=core2
>
> In response to device_add, CPU core device will be created. CPU core
> device creates and realizes CPU thread devices. If the machine type
> supports CPU hotplug, boot-time CPUs are created as CPU core devices
> otherwise they continue to be created as individual CPU devices.
>
> Set up device tree entries for the hotplugged CPU core and use the
> exising EPOW event infrastructure to send CPU hotplug notification to
> the guest.
>
> Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: David Gibson <address@hidden>
The logic here looks basically sound. Elswhere however I have
comments on the socket / core / package / whatnot interfaces that I'm
not entirely convinced by. Changes there are likely to require
changes here, although with luck not too big.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH v7 02/13] exec: Remove cpu from cpus list during cpu_exec_exit(), (continued)
- [Qemu-ppc] [PATCH v7 02/13] exec: Remove cpu from cpus list during cpu_exec_exit(), Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 04/13] cpu: Don't realize CPU from cpu_generic_init(), Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 06/13] cpu: Add a sync version of cpu_remove(), Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 05/13] cpu: Reclaim vCPU objects, Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 07/13] xics, xics_kvm: Handle CPU unplug correctly, Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 08/13] target-ppc: Introduce PowerPC specific CPU core device, Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 10/13] spapr: CPU hotplug support, Bharata B Rao, 2016/01/28
- Re: [Qemu-ppc] [PATCH v7 10/13] spapr: CPU hotplug support,
David Gibson <=
- [Qemu-ppc] [PATCH v7 09/13] spapr: Enable CPU hotplug for pseries-2.6 and add CPU DRC DT entries, Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 11/13] spapr: CPU hot unplug support, Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 12/13] qmp: Add query-ppc-cpu-cores command, Bharata B Rao, 2016/01/28
- [Qemu-ppc] [PATCH v7 13/13] hmp: Add "info ppc-cpu-cores" command, Bharata B Rao, 2016/01/28