[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCHv2 01/10] target-ppc: Remove unused kvmppc_read_seg
From: |
Thomas Huth |
Subject: |
Re: [Qemu-ppc] [PATCHv2 01/10] target-ppc: Remove unused kvmppc_read_segment_page_sizes() stub |
Date: |
Wed, 27 Jan 2016 13:16:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 27.01.2016 11:13, David Gibson wrote:
> This stub function is in the !KVM ifdef in target-ppc/kvm_ppc.h. However
> no such function exists on the KVM side, or is ever used.
>
> I think this originally referenced a function which read host page size
> information from /proc, for we we now use the KVM GET_SMMU_INFO extension
> instead.
>
> In any case, it has no function now, so remove it.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> target-ppc/kvm_ppc.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h
> index 5e1333d..62406ce 100644
> --- a/target-ppc/kvm_ppc.h
> +++ b/target-ppc/kvm_ppc.h
> @@ -98,11 +98,6 @@ static inline int kvmppc_get_hypercall(CPUPPCState *env,
> uint8_t *buf, int buf_l
> return -1;
> }
>
> -static inline int kvmppc_read_segment_page_sizes(uint32_t *prop, int
> maxcells)
> -{
> - return -1;
> -}
> -
> static inline int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level)
> {
> return -1;
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-ppc] [PATCHv2 09/10] target-ppc: Helper to determine page size information from hpte alone, (continued)
- [Qemu-ppc] [PATCHv2 09/10] target-ppc: Helper to determine page size information from hpte alone, David Gibson, 2016/01/27
- [Qemu-ppc] [PATCHv2 05/10] target-ppc: Use actual page size encodings from HPTE, David Gibson, 2016/01/27
- [Qemu-ppc] [PATCHv2 03/10] target-ppc: Rework ppc_store_slb, David Gibson, 2016/01/27
- [Qemu-ppc] [PATCHv2 02/10] target-ppc: Convert mmu-hash{32, 64}.[ch] from CPUPPCState to PowerPCCPU, David Gibson, 2016/01/27
- [Qemu-ppc] [PATCHv2 01/10] target-ppc: Remove unused kvmppc_read_segment_page_sizes() stub, David Gibson, 2016/01/27
- [Qemu-ppc] [PATCHv2 10/10] target-ppc: Allow more page sizes for POWER7 & POWER8 in TCG, David Gibson, 2016/01/27
- Re: [Qemu-ppc] [PATCHv2 00/10] Clean up page size handling for ppc 64-bit hash MMUs with TCG, Alexander Graf, 2016/01/28