[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PULL 01/28] target-ppc: Use sensible POWER8/POWER8E vers
From: |
Thomas Huth |
Subject: |
Re: [Qemu-ppc] [PULL 01/28] target-ppc: Use sensible POWER8/POWER8E versions |
Date: |
Mon, 25 Jan 2016 20:26:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 25.01.2016 20:14, Alexander Graf wrote:
>
>
> On 01/25/2016 02:15 AM, David Gibson wrote:
>> From: Benjamin Herrenschmidt <address@hidden>
>>
>> We never released anything older than POWER8 DD2.0 and POWER8E DD2.1,
>> so let's use these versions, without that some firmware or Linux code
>> might fail to use some HW features that were non functional in earlier
>> internal only spins of the chip.
>>
>> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
>> Signed-off-by: David Gibson <address@hidden>
>> ---
>> target-ppc/cpu-models.c | 12 ++++++------
>> target-ppc/cpu-models.h | 4 ++--
>> 2 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c
>> index 4d5ab4b..349783e 100644
>> --- a/target-ppc/cpu-models.c
>> +++ b/target-ppc/cpu-models.c
>> @@ -1138,10 +1138,10 @@
>> "POWER7 v2.3")
>> POWERPC_DEF("POWER7+_v2.1", CPU_POWERPC_POWER7P_v21,
>> POWER7,
>> "POWER7+ v2.1")
>> - POWERPC_DEF("POWER8E_v1.0", CPU_POWERPC_POWER8E_v10,
>> POWER8,
>> - "POWER8E v1.0")
>> - POWERPC_DEF("POWER8_v1.0", CPU_POWERPC_POWER8_v10,
>> POWER8,
>> - "POWER8 v1.0")
>
> Removing those breaks -cpu host on 1.0 machines, no?
I don't think so. The code in kvm_ppc_register_host_cpu_type()
explicitly registers a "host" CPU type with the PVR of the current host.
Apart from that, as mentioned in the patch description, v1.0 chips
apparently have never been released into the wild - and I guess the
unreleased v1.0 chips have all already scrapped nowadays ... so the
patch should be fine, I think.
Thomas
- [Qemu-ppc] [PULL 00/28] ppc-for-2.6 queue 20160125, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 04/28] macio: add dma_active to VMStateDescription, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 05/28] mac_dbdma: add DBDMA controller state to VMStateDescription, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 15/28] pseries: Clean up error handling in spapr_rtas_register(), David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 21/28] target-ppc: gdbstub: fix float registers for little-endian guests, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 17/28] pseries: Clean up error reporting in ppc_spapr_init(), David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 26/28] pseries: Allow TCG h_enter to work with hotplugged memory, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 03/28] macio: use the existing IDEDMA aiocb to hold the active DMA aiocb, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 01/28] target-ppc: Use sensible POWER8/POWER8E versions, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 09/28] spapr: Remove abuse of rtas_ld() in h_client_architecture_support, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 02/28] target-ppc: use cpu_write_xer() helper in cpu_post_load, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 10/28] spapr: Don't create ibm, dynamic-reconfiguration-memory w/o DR LMBs, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 16/28] pseries: Clean up error handling in xics_system_init(), David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 18/28] pseries: Clean up error reporting in htab migration functions, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 06/28] cuda: add missing fields to VMStateDescription, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 19/28] target-ppc: kvm: fix floating point registers sync on little-endian hosts, David Gibson, 2016/01/24
- [Qemu-ppc] [PULL 13/28] pseries: Clean up error handling in spapr_validate_node_memory(), David Gibson, 2016/01/24