[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 07/13] cuda: port RESET_SYSTEM command to new fram
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 07/13] cuda: port RESET_SYSTEM command to new framework |
Date: |
Mon, 25 Jan 2016 10:24:58 +1100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sat, Jan 23, 2016 at 09:40:04PM +0100, Hervé Poussineau wrote:
> Signed-off-by: Hervé Poussineau <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/misc/macio/cuda.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c
> index df4797f..70a5d0c 100644
> --- a/hw/misc/macio/cuda.c
> +++ b/hw/misc/macio/cuda.c
> @@ -613,11 +613,24 @@ static bool cuda_cmd_powerdown(CUDAState *s,
> return true;
> }
>
> +static bool cuda_cmd_reset_system(CUDAState *s,
> + const uint8_t *in_data, int in_len,
> + uint8_t *out_data, int *out_len)
> +{
> + if (in_len != 0) {
> + return false;
> + }
> +
> + qemu_system_reset_request();
> + return true;
> +}
> +
> static const CudaCommand handlers[] = {
> { CUDA_AUTOPOLL, "AUTOPOLL", cuda_cmd_autopoll },
> { CUDA_SET_AUTO_RATE, "SET_AUTO_RATE", cuda_cmd_set_autorate },
> { CUDA_SET_DEVICE_LIST, "SET_DEVICE_LIST", cuda_cmd_set_device_list },
> { CUDA_POWERDOWN, "POWERDOWN", cuda_cmd_powerdown },
> + { CUDA_RESET_SYSTEM, "RESET_SYSTEM", cuda_cmd_reset_system },
> };
>
> static void cuda_receive_packet(CUDAState *s,
> @@ -669,10 +682,6 @@ static void cuda_receive_packet(CUDAState *s,
> case CUDA_SET_POWER_MESSAGES:
> cuda_send_packet_to_host(s, obuf, 3);
> return;
> - case CUDA_RESET_SYSTEM:
> - cuda_send_packet_to_host(s, obuf, 3);
> - qemu_system_reset_request();
> - return;
> case CUDA_COMBINED_FORMAT_IIC:
> obuf[0] = ERROR_PACKET;
> obuf[1] = 0x5;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH 00/13] cuda: misc fixes and cleanups, Hervé Poussineau, 2016/01/23
- [Qemu-ppc] [PATCH 06/13] cuda: port POWERDOWN command to new framework, Hervé Poussineau, 2016/01/23
- [Qemu-ppc] [PATCH 04/13] cuda: port SET_AUTO_RATE command to new framework, Hervé Poussineau, 2016/01/23
- [Qemu-ppc] [PATCH 05/13] cuda: port SET_DEVICE_LIST command to new framework, Hervé Poussineau, 2016/01/23
- [Qemu-ppc] [PATCH 07/13] cuda: port RESET_SYSTEM command to new framework, Hervé Poussineau, 2016/01/23
- Re: [Qemu-ppc] [PATCH 07/13] cuda: port RESET_SYSTEM command to new framework,
David Gibson <=
- [Qemu-ppc] [PATCH 01/13] cuda: add a framework to handle commands, Hervé Poussineau, 2016/01/23
- [Qemu-ppc] [PATCH 02/13] cuda: reject unknown commands, Hervé Poussineau, 2016/01/23
- [Qemu-ppc] [PATCH 03/13] cuda: port AUTOPOLL command to new framework, Hervé Poussineau, 2016/01/23
- [Qemu-ppc] [PATCH 12/13] cuda: remove GET_6805_ADDR command, Hervé Poussineau, 2016/01/23