[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error report
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions |
Date: |
Tue, 19 Jan 2016 13:21:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
David Gibson <address@hidden> writes:
> On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote:
>> David Gibson <address@hidden> writes:
>>
>> > The functions for migrating the hash page table on pseries machine type
>> > (htab_save_setup() and htab_load()) can report some errors with an
>> > explicit fprintf() before returning an appropriate error code. Change
>> > these
>> > to use error_report() instead.
>> >
>> > Signed-off-by: David Gibson <address@hidden>
>> > Reviewed-by: Thomas Huth <address@hidden>
>> > ---
>> > hw/ppc/spapr.c | 12 ++++++------
>> > 1 file changed, 6 insertions(+), 6 deletions(-)
>> >
>> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
>> > index 3cfacb9..1eb7d03 100644
>> > --- a/hw/ppc/spapr.c
>> > +++ b/hw/ppc/spapr.c
>>
>> Lost this hunk:
>>
>> @@ -1309,8 +1309,9 @@ static int htab_save_setup(QEMUFile *f, void *opaque)
>> spapr->htab_fd = kvmppc_get_htab_fd(false);
>> spapr->htab_fd_stale = false;
>> if (spapr->htab_fd < 0) {
>> - fprintf(stderr, "Unable to open fd for reading hash table
>> from KVM: %s\n",
>> - strerror(errno));
>> + error_report(
>> + "Unable to open fd for reading hash table from KVM: %s",
>> + strerror(errno));
>> return -1;
>> }
>> }
>>
>> Intentional?
>
> Yes. As noted in the cover letter, this conflicts with another series
> I'm working on, which will obsolete this change anyway.
The patch doesn't quite hold what the commit message's promises, but I
guess that's okay. An "except for htab_save_setup()" in the commit
message wouldn't hurt, though.
- [Qemu-ppc] [PATCHv4 5/8] pseries: Clean up error handling in spapr_rtas_register(), (continued)
[Qemu-ppc] [PATCHv4 6/8] pseries: Clean up error handling in xics_system_init(), David Gibson, 2016/01/18
[Qemu-ppc] [PATCHv4 7/8] pseries: Clean up error reporting in ppc_spapr_init(), David Gibson, 2016/01/18
[Qemu-ppc] [PATCHv4 1/8] ppc: Cleanup error handling in ppc_set_compat(), David Gibson, 2016/01/18
[Qemu-ppc] [PATCHv4 3/8] pseries: Clean up error handling in spapr_validate_node_memory(), David Gibson, 2016/01/18
Re: [Qemu-ppc] [Qemu-devel] [PATCHv4 0/8] Cleanups to error reporting on ppc and spapr, Markus Armbruster, 2016/01/19