Re: [Qemu-ppc] [PATCH v4 0/8] target-arm: enable qmp-dump-guest-memory

[Peter Maydell]

On 11 January 2016 at 19:56, Andrew Jones <address@hidden> wrote:
> This series brings qmp-dump-guest-memory to arm and aarch64
> targets. I've detailed my testing and the results in the
> following table.
>
> v4:
>  - drop aarch64_compat_sp in favor of fixing crash[*] [Peter]
>  - added more Peter r-b's (fix 1 nit and 1 typo)
>
> [*] new crash fix: commit 4641ea1f6 https://github.com/crash-utility/crash
>
> v3:
>  - more changes thanks to Peter's review comments
>    - fix 32-to-64 shoehorning to work better with EL2/EL3
>    - stole comment from Peter for best-effort at endianness selection
>    - only make ARM VFP notes when the guest has VFP registers
>    - some more patch squashing and code commenting
>    - another r-b added
>  - collapsed a level of indirection, because if we're writing elf64 notes
>    then we'll always call the aarch64 function [drew]
>  - fixed the note type for ARM VFP notes (+ a tiny bit of refactoring) [drew]
>  - set prstatus.pr_fpvalid [drew]
>  - tested on tcg [drew]
>
> v2: changes thanks to Peter's review questions
>  - Threw in the FP registers. Can view them with gdb on elf
>    formatted dumps.
>  - Added comments stating where the register structs come from.
>  - Fixed determination of 32 vs. 64-bit and LE vs. BE formats.
>    Added a new config to the test matrix below to test this fix.
>  - Added a couple R-b's
>



Applied to target-arm.next, thanks.

-- PMM