[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH for-2.5 44/77] pci-bridge: Set a supported devfn_m
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-ppc] [PATCH for-2.5 44/77] pci-bridge: Set a supported devfn_min for bridge |
|
Date: |
Wed, 18 Nov 2015 18:38:41 +0200 |
On Wed, Nov 18, 2015 at 03:25:25PM +0100, Paolo Bonzini wrote:
>
>
> On 18/11/2015 15:21, Michael S. Tsirkin wrote:
> > This depends on the devfn_min thing, right?
> > I'm yet to review it, generally I'd prefer to
> > avoid changing device allocation rules since
> > that makes it so easy to break compatibility.
> >
> > Assuming addresses are all explicitly stated,
> > is there even a problem?
>
> It makes it a bit easier to use pci-bridge; it is a bug, albeit one that
> only affects direct usage through the command line of PCI bridges.
>
> Paolo
Yes but not a regression ... I'll look at how
invasive the change it depends on is.
- [Qemu-ppc] [PATCH 45/77] qdev: Add a hook for a bus to device if it can add devices, (continued)
[Qemu-ppc] [PATCH 41/77] ppc/pnv: Add LPC controller and hook it up with a UART and RTC, Benjamin Herrenschmidt, 2015/11/10
[Qemu-ppc] [PATCH 47/77] pci: Don't call pci_irq_handler() for a negative intx, Benjamin Herrenschmidt, 2015/11/10
[Qemu-ppc] [PATCH 46/77] pci: Use the new pci_can_add_device() to enforce devfn_min/max, Benjamin Herrenschmidt, 2015/11/10
[Qemu-ppc] [PATCH 43/77] ppc/pnv: Add OCC model stub with interrupt support, Benjamin Herrenschmidt, 2015/11/10
[Qemu-ppc] [PATCH 42/77] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt, Benjamin Herrenschmidt, 2015/11/10
[Qemu-ppc] [PATCH 50/77] ppc: Update LPCR definitions, Benjamin Herrenschmidt, 2015/11/10
[Qemu-ppc] [PATCH 49/77] ppc/pnv: Create a default PCI layout, Benjamin Herrenschmidt, 2015/11/10